Add next token #17
Merged
Add next token #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/lexer/lex.c
Outdated
| char prev; | ||
| if ((cur = fgetc(l->fp)) != EOF) { | ||
| prev = cur; | ||
| if (!(cur == ' ' || cur == '/')) { |
There was a problem hiding this comment.
Noted -- Fixing now.
There was a problem hiding this comment.
Should be resolved.
src/lexer/lex.c
Outdated
| } else { | ||
| return -1; // file done, no more tokens | ||
| } | ||
| // read each character from the file until EOF |
There was a problem hiding this comment.
I'm having a bit of trouble understanding what this section of code (until the end of the file) is doing, to be honest. Does this correctly handle a case like
/* Comment
number one*/ /* Comment number two*/ int x = 3;There was a problem hiding this comment.
That is just a check to make sure the file is not already over. If EOF is the next character, then it returns -1 meaning there are no tokens to get.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for jumping to next token (avoiding block comments and single line comments). Also skips leading spaces.
Essentially, this code works by stopping on the first character that is not considered to be a block comment.
Possible issue: May be missing an edge case where the wrong place is returned in the case of
#include <folder/file>. Will fix later if confirmed. Fixed.